Validate the key provided for the download #8

New Issue

paul · 2022-05-25T22:30:06+02:00

paul commented

2022-05-25 22:30:06 +02:00

Currrently, the key is passed on to a youtube-dl command-line without validation, this should be done! Also, maybe consider switching to the youtube_dl crate, after checking that it does the validation correctly.

It wouldn't hurt to have a type for the key/ID and implement FromForm for it.

Currrently, the key is passed on to a youtube-dl command-line without validation, this should be done! Also, maybe consider switching to the [youtube_dl](https:/lib.rs/youtube_dl) crate, after checking that it does the validation correctly. It wouldn't hurt to have a type for the key/ID and implement `FromForm` for it.

paul added the

bug

label 2022-05-25 22:30:06 +02:00

paul added this to the 0.2.0 milestone 2022-05-25 22:30:09 +02:00

paul self-assigned this 2022-05-25 22:30:27 +02:00

paul commented

2022-05-26 19:59:48 +02:00

We actually already use a type for the key/ID, namely PathBuf for which Rocket already implements the FromFrom trait which does not except any compromisable paths.

We actually already use a type for the key/ID, namely `PathBuf` for which Rocket already implements the `FromFrom` trait which does not except any compromisable paths.

paul referenced this issue from a commit

2022-05-26 20:39:10 +02:00

Replace own youtube-dl impl by youtube_dl crate (refs: #8)

paul closed this issue

2022-05-26 20:41:12 +02:00

Sign in to join this conversation.