Add more lints; fix issues

src/lib.rs

@@ -1,9 +1,17 @@
 #![doc = include_str!("../README.md")]
 #![warn(
     clippy::all,
+    missing_copy_implementations,
     missing_debug_implementations,
     rust_2018_idioms,
-    rustdoc::broken_intra_doc_links
+    rustdoc::broken_intra_doc_links,
+    trivial_casts,
+    trivial_numeric_casts,
+    renamed_and_removed_lints,
+    unsafe_code,
+    unstable_features,
+    unused_import_braces,
+    unused_qualifications
 )]
 #![deny(missing_docs)]
 
@@ -60,7 +68,7 @@ pub(crate) enum Error {
     UnsupportedMetric(Metric),
 }
 
-impl<'r, 'o: 'r> rocket::response::Responder<'r, 'o> for Error {
+impl<'r, 'o: 'r> Responder<'r, 'o> for Error {
     fn respond_to(self, _request: &'r Request<'_>) -> rocket::response::Result<'o> {
         eprintln!("💥 Encountered error during request: {}", self);
 

src/main.rs

@@ -1,9 +1,17 @@
 #![doc = include_str!("../README.md")]
 #![warn(
     clippy::all,
+    missing_copy_implementations,
     missing_debug_implementations,
     rust_2018_idioms,
-    rustdoc::broken_intra_doc_links
+    rustdoc::broken_intra_doc_links,
+    trivial_casts,
+    trivial_numeric_casts,
+    renamed_and_removed_lints,
+    unsafe_code,
+    unstable_features,
+    unused_import_braces,
+    unused_qualifications
 )]
 #![deny(missing_docs)]
 

src/maps.rs

@@ -393,7 +393,7 @@ fn sample<I: GenericImageView<Pixel = Rgba<u8>>>(
             .expect("Maximum color is always a map key color") as u8;
 
         samples.push(Sample { time, score });
-        time = time + chrono::Duration::seconds(interval as i64);
+        time += chrono::Duration::seconds(interval);
         offset += width;
     }
 

src/providers/buienradar.rs

@@ -106,7 +106,7 @@ fn fix_items_day_boundary(items: Vec<Item>) -> Vec<Item> {
             .into_iter()
             .map(|mut item| {
                 if item.time > noon {
-                    item.time = item.time - Duration::days(1)
+                    item.time -= Duration::days(1)
                 }
                 item
             })
@@ -117,7 +117,7 @@ fn fix_items_day_boundary(items: Vec<Item>) -> Vec<Item> {
             .into_iter()
             .map(|mut item| {
                 if item.time < noon {
-                    item.time = item.time + Duration::days(1)
+                    item.time += Duration::days(1)
                 }
                 item
             })