Maybe uses wrong base date when parsing Buienradar time #3

New Issue

paul · 2022-02-13T16:59:22+01:00

paul commented

2022-02-13 16:59:22 +01:00

The time in the rain text output is interpreted within the local date. However, when running this on a machine that is not in the Europe/Amsterdam time zone, the current date may different from the date in said time zone.

paul added the

bug

label 2022-02-13 16:59:22 +01:00

paul commented

2022-02-18 19:48:30 +01:00

With the chrono-tz crate it should possible to take the date from the Europe/Amsterdam time zone and then convert it to UTC?

With the `chrono-tz` crate it should possible to take the date from the Europe/Amsterdam time zone and then convert it to UTC?

admar commented

2022-02-18 20:33:19 +01:00

Buienradar maps (pollen and UVI) are already in UTC: forcast for 2022-02-18 20:00 has filename 02202181900__820x988_False_False_False_0_24_0_0_0.png

Luchtmeetnet also uses UTC in its forecasts.

The only service that does not use UTC is the Buienradar API.

Isn't it easier to convert the Buienradar API timestamp to UTC and use UTC throughout the rest of the application?

Buienradar maps (pollen and UVI) are already in UTC: forcast for 2022-02-18 20:00 has filename 0220218**1900**__820x988_False_False_False_0_24_0_0_0.png Luchtmeetnet also uses UTC in its forecasts. The only service that does not use UTC is the Buienradar API. Isn't it easier to convert the Buienradar API timestamp to UTC and use UTC throughout the rest of the application?

paul commented

2022-02-19 00:37:18 +01:00

Also, timestamps can cross the day limit, this also goes wrong. Or it can even go backward because it sometimes provides older forecasts.

paul self-assigned this 2022-02-19 15:39:30 +01:00

paul commented

2022-02-19 15:47:26 +01:00

Buienradar maps (pollen and UVI) are already in UTC: forcast for 2022-02-18 20:00 has filename 02202181900__820x988_False_False_False_0_24_0_0_0.png

Luchtmeetnet also uses UTC in its forecasts.

The only service that does not use UTC is the Buienradar API.

Isn't it easier to convert the Buienradar API timestamp to UTC and use UTC throughout the rest of the application?

Yes, but this is talking about the conversion process. You have to start with local time first and now it uses the server's local time instead of Europa/Amsterdams time (which Buienradar uses in its output).

> Buienradar maps (pollen and UVI) are already in UTC: forcast for 2022-02-18 20:00 has filename 0220218**1900**__820x988_False_False_False_0_24_0_0_0.png > > Luchtmeetnet also uses UTC in its forecasts. > > The only service that does not use UTC is the Buienradar API. > > Isn't it easier to convert the Buienradar API timestamp to UTC and use UTC throughout the rest of the application? Yes, but this is talking about the conversion process. You have to start with local time first and now it uses the server's local time instead of Europa/Amsterdams time (which Buienradar uses in its output).

paul referenced this issue from a commit

2022-02-20 17:42:18 +01:00

Fix Buienradar timestamp madness (closes: #3)

paul closed this issue

2022-02-20 17:42:18 +01:00

paul added this to the version 0.1.0 milestone 2022-03-14 17:03:50 +01:00

Sign in to join this conversation.