Properly handle (and log) errors #5

New Issue

paul · 2022-02-13T17:01:47+01:00

paul commented

2022-02-13 17:01:47 +01:00

Currently all errors are squashed by using Option and just returning None in case of an error.
It would be better to at least log the error when retrieving the forecast or updating the maps.

Currently all errors are squashed by using `Option` and just returning `None` in case of an error. It would be better to at least log the error when retrieving the forecast or updating the maps.

paul added the

enhancement

label 2022-02-13 17:01:47 +01:00

paul self-assigned this 2022-02-13 17:01:47 +01:00

paul commented

2022-02-21 21:10:27 +01:00

Maybe wait for https://github.com/SergioBenitez/Rocket/pull/1579?

paul commented

2022-03-14 16:50:49 +01:00

I propose to add the errors field to the JSON (following JSON:API in a way). Note that every metric can have its own errors, that is why it is an array.

So something like:

{
  "lat": 34.567890,
  "lon": 1.234567,
  "time": 1645800043,
  "errors": [
  	{
    	"code": "SomeErr",
        "title": "Something went wrong!",
        "detail": "..."
    }
}

These errors can then be logged.

I propose to add the `errors` field to the JSON (following [JSON:API](https://jsonapi.org/format/#errors) in a way). Note that every metric can have its own errors, that is why it is an array. So something like: ```json { "lat": 34.567890, "lon": 1.234567, "time": 1645800043, "errors": [ { "code": "SomeErr", "title": "Something went wrong!", "detail": "..." } } ``` These errors can then be logged.

paul added this to the 0.3.0 milestone 2022-03-14 17:05:02 +01:00

admar commented

2022-03-14 21:13:16 +01:00

I propose to add the errors field to the JSON (following JSON:API in a way). Note that every metric can have its own errors, that is why it is an array.

Then how do you know which metric is causing the error? Also: will metrics that did not cause an error still be part of the response?

> I propose to add the `errors` field to the JSON (following [JSON:API](https://jsonapi.org/format/#errors) in a way). Note that every metric can have its own errors, that is why it is an array. Then how do you know which metric is causing the error? Also: will metrics that did not cause an error still be part of the response?

paul added reference handle-errors

2022-05-08 15:06:58 +02:00

paul referenced this issue from paul/podbringer

2022-05-25 22:20:15 +02:00

Properly handle (and log) errors #6

paul referenced this issue

2022-06-05 17:01:31 +02:00

Sinoptik removes valid data from AQI source #23

paul referenced a pull request that will close this issue

2022-06-06 16:41:29 +02:00

Handle errors internally and show them via the API #25

paul closed this issue