paul/solar-grabber
paul
/
solar-grabber
2
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Releases 9 Activity

Handle bad behaviour by the Hoymiles API #7

New Issue
Closed
opened 2023-01-15 17:10:01 +01:00 by paul · 5 comments
paul commented 2023-01-15 17:10:01 +01:00
Owner
Copy Link

The following issues were found:

  • The status (error) code field is a number encoded as string
  • The data field in the API response can be an empty string (instead of null) in case of an error
  • At 0:00 (local time) the today_eq field in the API response is reset, but not at the some moment added to total_eq, leading to a decrease in the total until this is corrected
  • The last_data_time field in the API data as last updated timestamp but it has no timezone
  • The data is updated at about 15 minutes, but it seems to be slightly less, so it shifts slowly back in the poll interval of also 15 minutes
  • If the token becomes invalid, a valid API response is still returned and that might contain the error; this needs to be detected

Handle this behavior by various workarounds.

The following issues were found: * [x] The status (error) code field is a number encoded as string * [x] The `data` field in the API response can be an empty string (instead of `null`) in case of an error * [x] At 0:00 (local time) the `today_eq` field in the API response is reset, but not at the some moment added to `total_eq`, leading to a decrease in the total until this is corrected * [x] The `last_data_time` field in the API data as last updated timestamp but it has no timezone * [x] The data is updated at about 15 minutes, but it seems to be slightly less, so it shifts slowly back in the poll interval of also 15 minutes * [x] If the token becomes invalid, a valid API response is still returned and that might contain the error; this needs to be detected Handle this behavior by various workarounds.
paul added the
bug
 label 2023-01-15 17:10:05 +01:00
paul self-assigned this 2023-01-15 17:10:10 +01:00
paul changed title from Handle bad behaviour of the Hoymiles API to Handle bad behaviour by the Hoymiles API 2023-01-15 17:10:31 +01:00
paul commented 2023-01-15 17:11:41 +01:00
Author
Owner
Copy Link

The shifting every 15 minute update is fixed in commit 01416ee (and ef13f7e) by reducing the poll interval to 5 minutes.

The shifting every 15 minute update is fixed in commit 01416ee (and ef13f7e) by reducing the poll interval to 5 minutes.
paul commented 2023-01-15 17:12:27 +01:00
Author
Owner
Copy Link

The last_data_time field parsing and inclusion is added in commit e0151c3.

The `last_data_time` field parsing and inclusion is added in commit e0151c3.
paul commented 2023-01-15 17:13:00 +01:00
Author
Owner
Copy Link

The 0:00 reset breaking the non-decreasing total is fixed in commit d787c8b.

The 0:00 reset breaking the non-decreasing total is fixed in commit d787c8b.
paul commented 2023-01-15 17:13:46 +01:00
Author
Owner
Copy Link

The improved parsing of a possible empty data field and the status (error) code as string is implemented in commit 5a2889a.

The improved parsing of a possible empty `data` field and the status (error) code as string is implemented in commit 5a2889a.
paul commented 2023-01-16 20:09:22 +01:00
Author
Owner
Copy Link

The validation of the response (and status (error) code checking) was added in commit e1d70e8.

This was the last remaining issue.

The validation of the response (and status (error) code checking) was added in commit e1d70e8. This was the last remaining issue.
👍 1
paul closed this issue 2023-01-16 20:09:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
v0.3.5
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
v0.2.2
v0.2.1
v0.2.0
v0.1.1
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
paul
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: paul/solar-grabber#7
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?